Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to Cosmwasm-std 2.1 for Clone Testing #480

Merged
merged 14 commits into from
Sep 11, 2024
Merged

Update to Cosmwasm-std 2.1 for Clone Testing #480

merged 14 commits into from
Sep 11, 2024

Conversation

Kayanski
Copy link
Contributor

@Kayanski Kayanski commented Sep 3, 2024 •
edited
Loading

This PR aims at upgrading cosmwasm-std to 2.1 inside clone testing.

This depends on AbstractSDK/cw-multi-test-fork#7

Dependencies

  • Clone-Testing now depends on the published version of cw-orch for compatibility reasons, because clone-testing depends on cw-multi-test-clone-testing which in turns depends on cw-orch. So we use the published version inside the dependencies and use a patch inside the workspace to make sure everything is compatible.

Checklist

  • Changelog updated.
  • Docs updated.

@cloudflare-workers-and-pages Cloudflare Workers and Pages
Copy link

cloudflare-workers-and-pages bot commented Sep 3, 2024 •
edited
Loading

Deploying cw-orchestrator with  Cloudflare Pages  Cloudflare Pages

Latest commit: e0aff05
Status: ✅  Deploy successful!
Preview URL: https://194b29dc.cw-orchestrator.pages.dev
Branch Preview URL: https://nicolas-orc-159-cw-orch-clon.cw-orchestrator.pages.dev

View logs

@codecov Codecov
Copy link

codecov bot commented Sep 3, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 30.00000% with 7 lines in your changes missing coverage. Please review.

Project coverage is 55.8%. Comparing base (cbab5f5) to head (221391f).

Files with missing lines Patch % Lines
packages/clone-testing/src/queriers/wasm.rs 16.6% 5 Missing ⚠️
packages/clone-testing/src/core.rs 50.0% 2 Missing ⚠️
Additional details and impacted files
Files with missing lines Coverage Δ
packages/clone-testing/src/queriers/bank.rs 82.1% <ø> (ø)
packages/clone-testing/src/core.rs 82.8% <50.0%> (ø)
packages/clone-testing/src/queriers/wasm.rs 32.9% <16.6%> (ø)

... and 9 files with indirect coverage changes

Buckram123
Buckram123 approved these changes Sep 4, 2024
View reviewed changes
Copy link
Contributor

@Buckram123 Buckram123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small nit, LGTM

packages/clone-testing/Cargo.toml Outdated Show resolved Hide resolved
CyberHoward
CyberHoward reviewed Sep 4, 2024
View reviewed changes
Cargo.toml Outdated Show resolved Hide resolved
@CyberHoward CyberHoward mentioned this pull request Sep 4, 2024
Merged
2 tasks
@Kayanski
Re-use contract's WASM compilation (#481)
26c651b 
* Adapt to cw-multi-test compile caching

* formatting
@Kayanski Kayanski merged commit 6e5687f into main Sep 11, 2024
9 of 13 checks passed
@Kayanski Kayanski deleted the nicolas/orc-159-cw-orch-clone-testing-20 branch September 11, 2024 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Buckram123 Buckram123 Buckram123 approved these changes

@CyberHoward CyberHoward CyberHoward approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Kayanski @CyberHoward @Buckram123